Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pysb branch #2548

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix pysb branch #2548

merged 1 commit into from
Oct 17, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 17, 2024

Previous branch no longer exists. Now on master (pysb/pysb@8be8263).

Previous branch no longer exists. Now on master.
@dweindl dweindl requested a review from a team as a code owner October 17, 2024 10:38
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.75%. Comparing base (2c957c8) to head (7e85f84).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2548      +/-   ##
===========================================
- Coverage    77.79%   77.75%   -0.05%     
===========================================
  Files          325      325              
  Lines        21058    21058              
  Branches      1473     1473              
===========================================
- Hits         16383    16373      -10     
- Misses        4648     4658      +10     
  Partials        27       27              
Flag Coverage Δ
cpp 73.46% <ø> (-0.05%) ⬇️
cpp_python 34.05% <ø> (ø)
petab 37.05% <ø> (ø)
python 72.29% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/petab/util.py 86.66% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@dweindl dweindl merged commit d4bb0ce into AMICI-dev:develop Oct 17, 2024
18 of 20 checks passed
@dweindl dweindl deleted the fix_pysb_branch branch October 17, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants