Fix _collect_heaviside_roots for sympy.Heaviside arguments
#2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if dxdt was a sympy.Heaviside, it wasn't correctly processed, because only its arguments were checked. That means, root-finding would not be enabled for this discontinuity. This would happen if a Rule or KineticLaw is a plain Piecewise function (not embedded inside a more complex expression). Fixes AMICI-dev#2545.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2549 +/- ##
===========================================
- Coverage 77.79% 77.74% -0.06%
===========================================
Files 325 325
Lines 21058 21852 +794
Branches 1473 1473
===========================================
+ Hits 16383 16988 +605
- Misses 4648 4837 +189
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since b7a3e91, if dxdt was a sympy.Heaviside, it wasn't correctly processed, because only its arguments were checked. That means, root-finding would not be enabled for this discontinuity.
This would happen if a Rule or KineticLaw is a plain Piecewise function (not embedded inside a more complex expression).
Fixes #2545.
The bug was exposed only after the previous release, this did not affect any former amici releases.