Fix dangling pointer in SolverTest.SettersGettersWithSetup #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweindl
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2556 +/- ##
===========================================
- Coverage 77.78% 77.75% -0.04%
===========================================
Files 325 325
Lines 21852 21852
Branches 1473 1473
===========================================
- Hits 16998 16991 -7
- Misses 4827 4834 +7
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. |
FFroehlich
approved these changes
Oct 19, 2024
dweindl
added a commit
that referenced
this pull request
Oct 20, 2024
Fixes a dangling pointer issue in SolverTest.SettersGettersWithSetup. The SUNContext was destroyed before the associated AmiVectors which resulted in invalid reads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a dangling pointer issue in SolverTest.SettersGettersWithSetup.
The SUNContext was destroyed before the associated AmiVectors which resulted in invalid reads.