Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for writing ExpData to HDF5 #2588

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 20, 2024

So far, there was only a H5File-based version, which is inconvenient to use from Python.

This allows passing a file name instead.

So far, there was only a H5File-based version, which is inconvenient to use from Python.

This allows passing a file name instead.
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.63%. Comparing base (2a25b27) to head (8d589f8).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/hdf5.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2588      +/-   ##
===========================================
+ Coverage    77.60%   77.63%   +0.03%     
===========================================
  Files          329      329              
  Lines        22055    22059       +4     
  Branches      1456     1456              
===========================================
+ Hits         17116    17126      +10     
+ Misses        4928     4922       -6     
  Partials        11       11              
Flag Coverage Δ
cpp 73.57% <0.00%> (+0.03%) ⬆️
cpp_python 34.30% <0.00%> (-0.01%) ⬇️
petab 37.24% <0.00%> (-0.01%) ⬇️
python 72.39% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/hdf5.cpp 89.01% <0.00%> (-0.50%) ⬇️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@dweindl dweindl marked this pull request as ready for review November 23, 2024 16:36
@dweindl dweindl requested a review from a team as a code owner November 23, 2024 16:36
@dweindl dweindl merged commit f42cc16 into AMICI-dev:develop Nov 23, 2024
17 of 20 checks passed
@dweindl dweindl deleted the write_edata_hdf5 branch November 23, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants