Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix installation of homebrew packages #2594

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 23, 2024

Things started failing yesterday(?), seemingly because of a pre-installed pkgconf interfering with the one to be installed as hdf5 dependency.

@dweindl dweindl marked this pull request as ready for review November 23, 2024 17:47
@dweindl dweindl requested a review from a team as a code owner November 23, 2024 17:47
Things started failing yesterday(?), seemingly because of a pre-installed pkgconf interfering with the one to be installed as hdf5 dependency.
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.61%. Comparing base (f42cc16) to head (5237787).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
python/sdist/amici/__main__.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2594       +/-   ##
============================================
+ Coverage    37.11%   77.61%   +40.49%     
============================================
  Files          329      329               
  Lines        21568    22061      +493     
  Branches      1452     1456        +4     
============================================
+ Hits          8006    17123     +9117     
+ Misses       13538     4927     -8611     
+ Partials        24       11       -13     
Flag Coverage Δ
cpp 73.55% <0.00%> (?)
cpp_python 34.30% <0.00%> (-0.01%) ⬇️
petab 37.23% <0.00%> (-0.01%) ⬇️
python 72.38% <0.00%> (+40.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/__main__.py 0.00% <0.00%> (ø)

... and 253 files with indirect coverage changes

---- 🚨 Try these New Features:

@dweindl dweindl merged commit 7ba2165 into AMICI-dev:develop Nov 23, 2024
17 of 20 checks passed
@dweindl dweindl deleted the fix_ci_mac branch November 23, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants