Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate pre-equilibration and dynamic simulation in jax #2617

Merged
merged 15 commits into from
Dec 5, 2024

Conversation

FFroehlich
Copy link
Member

@FFroehlich FFroehlich commented Dec 4, 2024

Prepares for timeseries implementation. Also fixes some issues with jax compilation that snuck into the develop branch.

TODO:

  • repair symlink (thanks for nothing pycharm)
  • update jax petab notebook
  • properly separate jax & cpp modules

@FFroehlich FFroehlich mentioned this pull request Dec 4, 2024
10 tasks
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.88%. Comparing base (d1c8250) to head (d972f3e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
python/sdist/amici/jax/model.py 41.66% 7 Missing ⚠️
python/sdist/amici/jax/petab.py 20.00% 4 Missing ⚠️
python/sdist/amici/petab/sbml_import.py 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2617      +/-   ##
===========================================
- Coverage    77.89%   77.88%   -0.01%     
===========================================
  Files          330      330              
  Lines        21834    21845      +11     
  Branches      1477     1477              
===========================================
+ Hits         17007    17014       +7     
- Misses        4816     4820       +4     
  Partials        11       11              
Flag Coverage Δ
cpp 74.13% <42.30%> (-0.02%) ⬇️
cpp_python 33.64% <11.53%> (-0.01%) ⬇️
petab 36.45% <19.23%> (-0.01%) ⬇️
python 72.47% <46.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/jax/ode_export.py 97.95% <100.00%> (-0.05%) ⬇️
python/sdist/amici/petab/import_helpers.py 86.95% <100.00%> (+1.01%) ⬆️
python/sdist/amici/petab/petab_import.py 66.66% <ø> (ø)
python/sdist/amici/petab/sbml_import.py 73.55% <66.66%> (+0.22%) ⬆️
python/sdist/amici/jax/petab.py 71.76% <20.00%> (-1.41%) ⬇️
python/sdist/amici/jax/model.py 75.00% <41.66%> (-1.35%) ⬇️

@FFroehlich FFroehlich marked this pull request as ready for review December 5, 2024 19:58
@FFroehlich FFroehlich requested a review from a team as a code owner December 5, 2024 19:58
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@FFroehlich FFroehlich merged commit 449041d into develop Dec 5, 2024
28 of 32 checks passed
@FFroehlich FFroehlich deleted the jax_separate_preeq_dyn branch December 5, 2024 23:40
Copy link

sonarqubecloud bot commented Dec 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants