Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark JAX experimental #2618

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Mark JAX experimental #2618

merged 2 commits into from
Dec 5, 2024

Conversation

FFroehlich
Copy link
Member

No description provided.

@FFroehlich FFroehlich requested a review from a team as a code owner December 5, 2024 20:20
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


from amici.jax.petab import JAXProblem, run_simulations
from amici.jax.model import JAXModel

warn(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be added to the ignore list in pytest.ini, I think.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.89%. Comparing base (0d49041) to head (f1cb799).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2618   +/-   ##
========================================
  Coverage    77.89%   77.89%           
========================================
  Files          330      330           
  Lines        21833    21834    +1     
  Branches      1477     1477           
========================================
+ Hits         17006    17007    +1     
  Misses        4816     4816           
  Partials        11       11           
Flag Coverage Δ
cpp 74.14% <100.00%> (+<0.01%) ⬆️
cpp_python 33.65% <0.00%> (-0.01%) ⬇️
petab 36.45% <0.00%> (-0.01%) ⬇️
python 72.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/jax/__init__.py 100.00% <100.00%> (ø)

Copy link

sonarqubecloud bot commented Dec 5, 2024

@FFroehlich FFroehlich merged commit d1c8250 into develop Dec 5, 2024
30 of 32 checks passed
@FFroehlich FFroehlich deleted the jax_experimental branch December 5, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants