Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State reinitialisation in JAX #2619

Merged
merged 29 commits into from
Dec 8, 2024
Merged

State reinitialisation in JAX #2619

merged 29 commits into from
Dec 8, 2024

Conversation

FFroehlich
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 94.16667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.13%. Comparing base (449041d) to head (c6b9cae).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
python/sdist/amici/jax/model.py 88.67% 6 Missing ⚠️
python/sdist/amici/jax/petab.py 98.48% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2619       +/-   ##
============================================
+ Coverage    36.57%   78.13%   +41.56%     
============================================
  Files          330      330               
  Lines        21845    21947      +102     
  Branches      1477     1477               
============================================
+ Hits          7990    17149     +9159     
+ Misses       13831     4787     -9044     
+ Partials        24       11       -13     
Flag Coverage Δ
cpp 73.98% <50.83%> (?)
cpp_python 33.49% <0.00%> (-0.16%) ⬇️
petab 38.35% <91.66%> (+1.89%) ⬆️
python 72.37% <50.83%> (+41.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/jax/__init__.py 100.00% <100.00%> (+100.00%) ⬆️
python/sdist/amici/jax/ode_export.py 97.95% <ø> (+97.95%) ⬆️
python/sdist/amici/petab/sbml_import.py 73.55% <ø> (ø)
python/sdist/amici/jax/petab.py 98.63% <98.48%> (+98.63%) ⬆️
python/sdist/amici/jax/model.py 85.40% <88.67%> (+85.40%) ⬆️

... and 243 files with indirect coverage changes

@FFroehlich FFroehlich mentioned this pull request Dec 6, 2024
10 tasks
@FFroehlich FFroehlich marked this pull request as ready for review December 6, 2024 13:40
@FFroehlich FFroehlich requested a review from a team as a code owner December 6, 2024 13:40
Comment on lines 225 to 227
petab.LIN: 0,
petab.LOG: 1,
petab.LOG10: 2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have some enum/constants here, or at least have a reference to where the values are defined/used.

Copy link

sonarqubecloud bot commented Dec 7, 2024

@FFroehlich FFroehlich merged commit f9e64de into develop Dec 8, 2024
30 of 32 checks passed
@FFroehlich FFroehlich deleted the jax_reinitialisation branch December 8, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants