Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Skip llh test for Isensee_JCB2018 #2621

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 9, 2024

Until it has been decided which model/dataset is the correct one, and the expected llh is updated accordingly.

See Benchmarking-Initiative/Benchmark-Models-PEtab#253

Until it has been decided which model/dataset is the correct one, and the expected llh is updated accordingly.

See Benchmarking-Initiative/Benchmark-Models-PEtab#253
@dweindl dweindl requested a review from a team as a code owner December 9, 2024 09:27
@dweindl dweindl enabled auto-merge December 9, 2024 09:27
@dweindl dweindl self-assigned this Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.00%. Comparing base (f9e64de) to head (4a23431).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2621      +/-   ##
===========================================
- Coverage    78.10%   77.00%   -1.10%     
===========================================
  Files          330      332       +2     
  Lines        21947    22957    +1010     
  Branches      1477     1477              
===========================================
+ Hits         17142    17679     +537     
- Misses        4794     5267     +473     
  Partials        11       11              
Flag Coverage Δ
cpp 73.93% <ø> (-0.02%) ⬇️
cpp_python 33.49% <ø> (ø)
petab 38.35% <ø> (ø)
python 72.08% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 57 files with indirect coverage changes

@dweindl dweindl added this pull request to the merge queue Dec 9, 2024
Merged via the queue into AMICI-dev:develop with commit 5e938b1 Dec 10, 2024
19 of 20 checks passed
@dweindl dweindl deleted the exclude_isensee branch December 10, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants