Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid silent preequilibration failure in JAX #2631

Merged
merged 14 commits into from
Dec 19, 2024
Merged

Avoid silent preequilibration failure in JAX #2631

merged 14 commits into from
Dec 19, 2024

Conversation

FFroehlich
Copy link
Member

fixes #2628

@FFroehlich FFroehlich requested a review from a team as a code owner December 17, 2024 10:11
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.08%. Comparing base (3d73624) to head (f1b3ee7).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2631      +/-   ##
===========================================
- Coverage    77.62%   77.08%   -0.54%     
===========================================
  Files          332      332              
  Lines        22967    22970       +3     
  Branches      1478     1478              
===========================================
- Hits         17827    17707     -120     
- Misses        5129     5252     +123     
  Partials        11       11              
Flag Coverage Δ
cpp 74.20% <100.00%> (-0.38%) ⬇️
cpp_python 33.47% <0.00%> (-0.01%) ⬇️
petab 38.31% <100.00%> (+<0.01%) ⬆️
python 72.17% <100.00%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/jax/model.py 87.16% <100.00%> (+0.17%) ⬆️
python/sdist/amici/jax/petab.py 98.13% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

@FFroehlich FFroehlich enabled auto-merge December 17, 2024 20:24
@FFroehlich FFroehlich added this pull request to the merge queue Dec 18, 2024
Merged via the queue into develop with commit 1716181 Dec 19, 2024
31 of 32 checks passed
@FFroehlich FFroehlich deleted the fix_2628 branch December 19, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants