Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RDataReporting::observables_likelihood #2633

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 19, 2024

Fixes #2627. ReturnData.sllh was always NaN because it wasn't 0-initialized.

Fixes AMICI-dev#2627. ReturnData.sllh was always NaN because it wasn't 0-initialized.
@dweindl dweindl requested a review from a team as a code owner December 19, 2024 14:14
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (1716181) to head (326cbac).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2633   +/-   ##
========================================
  Coverage    77.03%   77.03%           
========================================
  Files          332      332           
  Lines        22970    22971    +1     
  Branches      1478     1478           
========================================
+ Hits         17695    17696    +1     
  Misses        5264     5264           
  Partials        11       11           
Flag Coverage Δ
cpp 74.15% <100.00%> (+<0.01%) ⬆️
cpp_python 33.47% <100.00%> (+<0.01%) ⬆️
petab 38.31% <100.00%> (+<0.01%) ⬆️
python 72.11% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/rdata.cpp 95.61% <100.00%> (+<0.01%) ⬆️

@dweindl dweindl added this pull request to the merge queue Dec 19, 2024
Merged via the queue into AMICI-dev:develop with commit 92a530b Dec 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants