[WIP] clean-up the transverse flux correction #1920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
The transverse flux correction is done to the conserved interface state variables after we do the normal interface prediction. Previously we were doing a transverse correction on p in order to have enough of a thermodynamic state to get back the primitive state after the correction. Now we instead just work with the conserved state and call the EOS at the end to ensure consistency.
As part of this change, we now do the dual energy formulation consistent with how it is done in ctoprim.
This also fixes an issue with the reset of the state if rho < 0 -- we were not resetting the passives in this case.
PR motivation
PR checklist
CHANGES
file has been updated, if appropriate