Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert compute_lamborder to C++ #2581

Merged
merged 27 commits into from
Oct 7, 2023

Conversation

maxpkatz
Copy link
Member

PR summary

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz maxpkatz marked this pull request as ready for review September 24, 2023 19:00
@zingale
Copy link
Member

zingale commented Sep 24, 2023

Source/radiation/MGFLD.cpp Outdated Show resolved Hide resolved
Source/radiation/MGFLD.cpp Outdated Show resolved Hide resolved
@maxpkatz
Copy link
Member Author

maxpkatz commented Oct 7, 2023

The latest version of this PR fixes the code to make sense in all dimensions. It does this by using temporary filter arrays for the x and y dimensions in 2D and 3D respectively. It also significantly condenses the code by writing a generalized filter function (and accompanying function to load the "stencil" for both lambda and Er). This should reduce the likelihood of mistakes in the code. The boundary step at the end is also simplified into a simple loop over the entire box that copies zones from the edges and corners into the corresponding locations outside the valid region.

@zingale
Copy link
Member

zingale commented Oct 7, 2023

@zingale zingale merged commit fb5ad00 into AMReX-Astro:development Oct 7, 2023
18 checks passed
@maxpkatz maxpkatz deleted the cxx-compute-lamborder branch October 7, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants