Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse the simplified-SDC integrator for the ODE update #2584

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Sep 25, 2023

this eliminates all of the custom VODE code here

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

this eliminates all of the custom VODE code here
@zingale zingale added the sdc label Sep 25, 2023
@zingale
Copy link
Member Author

zingale commented Sep 25, 2023

this requires: AMReX-Astro/Microphysics#1341

@zingale
Copy link
Member Author

zingale commented Sep 25, 2023

this shows the expected 4th order convergence in reacting_convergence:

 $\rho$                           2.135967e+17   3.850       1.481741e+16   3.959       9.528251e+14
 $\rho u$                          3.41459e+25   3.849       2.369186e+24   3.948       1.535472e+23
 $\rho v$                          3.41459e+25   3.849       2.369186e+24   3.948       1.535472e+23
 $\rho E$                          1.95356e+34   3.884       1.323478e+33   3.938       8.637672e+31
 $\rho e$                         1.678975e+34   3.892       1.130798e+33   3.940       7.365531e+31
 $T$                              1.251912e+20   3.710       9.563941e+18   3.966       6.119475e+17
 $\rho X(\isotm{He}{4})$          2.156035e+17   3.852       1.492992e+16   3.957       9.610957e+14
 $\rho X(\isotm{C}{12})$          8.879796e+15   3.791       6.414778e+14   3.939       4.182066e+13
 $\rho X(\isotm{O}{16})$          5.791356e+12   3.747       4.312966e+11   3.915       2.859503e+10
 $\rho X(\isotm{Fe}{56})$             21359610   3.850            1481740   3.959           95282.51

@zingale zingale changed the title [WIP] reuse the simplified-SDC integrator for the ODE update reuse the simplified-SDC integrator for the ODE update Sep 26, 2023
@zingale
Copy link
Member Author

zingale commented Sep 29, 2023

this is ready now

@zingale zingale merged commit 4d895d9 into AMReX-Astro:development Sep 29, 2023
18 checks passed
@zingale zingale deleted the sdc_vode_cleanup branch September 29, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants