Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce clang-tidy via CI #2802

Merged
merged 28 commits into from
Mar 27, 2024
Merged

Enforce clang-tidy via CI #2802

merged 28 commits into from
Mar 27, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Mar 25, 2024 •
edited
Loading

PR summary

This sets up a new action for running clang-tidy 17 and it will abort if it produces
any warnings. At the moment, it runs on flame_wave and only evaluates the
Castro source, not any AMReX or Microphysics source.

We use the dependency script from AMReX to install clang-tidy 17

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
make clang-tidy recognize .H as a header
fa8374a
@zingale
remove static headers
bc01cf2
@zingale
almost there...
7dd8e15
@zingale
this seems to work
63dfc98
@zingale
fix spelling
437ebcb
@zingale
change MAX_LEV to constexpr
4c9cfb6
@zingale
sort the struct entries by type to reduce padding
40b05b9
@zingale
use ranged-for for problem parameter array init
6125f11
@zingale
Merge branch 'max_lev' into enforce_clang_tidy_ci
fd7f880
@zingale
Merge branch 'params_in_cpp_instead_of_header' into enforce_clang_tid…
98b5666 
…y_ci
@zingale
Merge branch 'clang-tidy-header' into enforce_clang_tidy_ci
9a8e70f
@zingale
fix another repeated branch in the logs
11ef0db 
this was missed earlier because we didn't have gravity enabled
@zingale
Merge branch 'one_more_log_fix' into enforce_clang_tidy_ci
84479fd
@zingale
address some clang-tidy warnings in gravity
a95f4fb
@zingale
Merge branch 'clang-tidy-gravity' into enforce_clang_tidy_ci
3553c3d
@zingale
fix a fix
bc4c68c
@zingale
Merge branch 'clang-tidy-gravity' into enforce_clang_tidy_ci
f2829e7
@zingale
add a clang-tidy check
58631f1
@zingale
fix path
6592d23
@zingale
disable MPI
5931fb3
@zingale
fix ignores
1476d4c
@zingale
fix again
0b549c6
@zingale
Merge branch 'development' into enforce_clang_tidy_ci
d9225e0
@zingale zingale changed the title [WIP] Enforce clang-tidy via CI Enforce clang-tidy via CI Mar 26, 2024
@zingale zingale merged commit 931e173 into AMReX-Astro:development Mar 27, 2024
24 checks passed
@zingale zingale deleted the enforce_clang_tidy_ci branch March 27, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @yut23