Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make clean should remove temporary .cpp files too #2812

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Apr 4, 2024

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented Apr 4, 2024

I guess this is kinda redundant though, since it appears that amrex removes all of tmp_build_dir

maybe this is a vestige from when clean and realclean did different things?

@yut23
Copy link
Collaborator

yut23 commented Apr 4, 2024

Also, CASTRO_AUTO_SOURCE_DIR will only be correct if you specify all the right variables (USE_MPI, DEBUG, etc.) when you call make clean.

@zingale
Copy link
Member Author

zingale commented Apr 4, 2024

right. I think that this goes back to the old difference between make clean and make realclean, which no longer exists anymore

@zingale zingale merged commit e55e04d into AMReX-Astro:development Apr 7, 2024
24 checks passed
@zingale zingale deleted the clean_up_temp_cpp branch April 7, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants