Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more amr.* stuff to job_info #2828

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Apr 19, 2024

in particular, this adds blocking_factor, n_error_buf, regrid_int, max_grid_size, and subcycling_mode

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

in particular, this adds blocking_factor, n_error_buf, max_grid_size,
and subcycling_mode
Copy link
Collaborator

@yut23 yut23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the flame_wave benchmark

@zingale
Copy link
Member Author

zingale commented Apr 19, 2024

I don't think so. These don't appear in `Inputs File Parameters", since they are not controlled by Castro's runtime parameter mechanism.

@yut23
Copy link
Collaborator

yut23 commented Apr 19, 2024

Oh, I see now. Looks fine to me.

@zingale zingale merged commit 5f44c13 into AMReX-Astro:development Apr 19, 2024
26 checks passed
@zingale zingale deleted the more_job_info branch April 19, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants