Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modernize _prob_params to use string #2845

Merged
merged 1 commit into from
May 22, 2024
Merged

modernize _prob_params to use string #2845

merged 1 commit into from
May 22, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented May 7, 2024

this removes old Fortran callbacks

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
modernize _prob_params to use string
cc1a1e2 
this removes old Fortran callbacks
@zingale zingale merged commit f7309fc into AMReX-Astro:development May 22, 2024
25 checks passed
@zingale zingale deleted the char_to_string branch May 22, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanakbhargava khanakbhargava khanakbhargava approved these changes

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zingale @yut23 @khanakbhargava