Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update local area and volume calculations for 2D spherical geometry #2953

Merged
merged 5 commits into from
Sep 10, 2024
Merged

update local area and volume calculations for 2D spherical geometry #2953

merged 5 commits into from
Sep 10, 2024

Conversation

zhichen3
Copy link
Collaborator

@zhichen3 zhichen3 commented Sep 8, 2024

This adds local area and volume calculations for 2D spherical geometry. We assume dx[0] = dr and dx[1] = dtheta.
This is to deal with issue #2927.

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zhichen3 zhichen3 marked this pull request as ready for review September 8, 2024 22:09
@zingale zingale merged commit a12d278 into AMReX-Astro:development Sep 10, 2024
25 checks passed
@zingale zingale mentioned this pull request Sep 12, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhichen3 @zingale