update primitive variable reconstruction with spherical 2d geometry. #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pm_source_tracing
|
it turns out dloga really just takes care of everything. Also made sure to use dt/rdtheta for dtdx, which I changed to dtdL |
|
I think this is good after we merge #2473 |
zhichen3
changed the title
|
can you resolve the conflicts? |
zingale
approved these changes
Sep 26, 2024
5 tasks
zingale
pushed a commit
that referenced
this pull request
Nov 17, 2024
computes dloga in y-direction and pass in the correct dloga for the corresponding dir. This was missed in pr #2964 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
addresses #2927 primitive variable source terms in ppm trace for spherical 2d geometry.
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate