New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2d spherical boundary condition check #2981

Merged

zingale merged 1 commit into AMReX-Astro:development from zhichen3:2d_spherical_bc_assert

Oct 23, 2024

Collaborator

zhichen3 commented Oct 23, 2024

PR summary

make sure we use symmetry boundary condition when theta is 0 and pi

PR motivation

PR checklist

test suite needs to be run on this PR
this PR will change answers in the test suite to more than roundoff level
all newly-added functions have docstrings as per the coding conventions
the CHANGES file has been updated, if appropriate
if appropriate, this change is described in the docs


          update checks on bc for spherical2d

2952a99

zingale approved these changes

View reviewed changes

zingale merged commit 1686df3 into AMReX-Astro:development

25 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet