Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some color to the output #463

Merged
merged 3 commits into from
May 17, 2024
Merged

add some color to the output #463

merged 3 commits into from
May 17, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented May 17, 2024

No description provided.

@zingale zingale requested a review from biboyd May 17, 2024 15:46
@zingale
Copy link
Member Author

zingale commented May 17, 2024

we might want to output some of the warnings in the base state stuff as orange, but right now, we manage those through the simple_log. See #464

@zingale
Copy link
Member Author

zingale commented May 17, 2024

this is what the output looks like with this PR:

image

@biboyd
Copy link
Collaborator

biboyd commented May 17, 2024

This looks good, outside those warnings there is an error message in MaestroBurner.cpp we might want to make red

amrex::Print() << "ERROR: abundances do not sum to 1";

@zingale
Copy link
Member Author

zingale commented May 17, 2024

updated the burner error

@zingale
Copy link
Member Author

zingale commented May 17, 2024

actually, should we really be using amrex::Print() in the burner? I think that code is run on all processors, so the processor that has the problem should output it.

Copy link
Collaborator

@biboyd biboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me now

@biboyd biboyd merged commit e8db3be into AMReX-Astro:development May 17, 2024
11 checks passed
@zingale zingale deleted the color branch May 17, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants