Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CMake: Replace FetchContent_Populate #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Aug 30, 2024

In CMake superbuilds, FetchContent_Populate is now deprecated. Use FetchContent_MakeAvailable instead.

  • Bump CMake to 2.24+ to have the latest behavioral changes in it. We anyway need a bump as we will soon rework the CUDA/HIP language support from AMReX to downstream.

See AMReX-Codes/pyamrex#359

@ax3l ax3l force-pushed the fix-cmake-fetch-content branch 3 times, most recently from e88d29e to 2b23d48 Compare August 30, 2024 03:08
In CMake superbuilds, `FetchContent_Populate` is now deprecated.
Use `FetchContent_MakeAvailable` instead.
@ax3l ax3l marked this pull request as ready for review August 30, 2024 03:26
@ax3l ax3l requested a review from WeiqunZhang August 30, 2024 03:26
@ax3l ax3l changed the title [WIP] CMake: Replace FetchContent_Populate CMake: Replace FetchContent_Populate Aug 30, 2024
@ax3l ax3l added the enhancement New feature or request label Aug 30, 2024
@ax3l ax3l changed the title CMake: Replace FetchContent_Populate [WIP}CMake: Replace FetchContent_Populate Aug 30, 2024
@ax3l ax3l changed the title [WIP}CMake: Replace FetchContent_Populate [WIP] CMake: Replace FetchContent_Populate Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant