Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort: AMReX as First Party Module #304

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 29, 2024

Declare amrex our first party module, even if it is not installed yet. This resolves inconsistencies when sorting imports in developer or remote runs (pre-commit.com CI).

Declare `amrex` our first party module, even if it is
not installed yet. This resolves inconsistencies when
sorting imports in developer or remote runs (pre-commit.com CI).
@ax3l ax3l added bug Something isn't working component: tests tests and examples labels Apr 29, 2024
@ax3l ax3l enabled auto-merge (squash) April 29, 2024 07:20
@ax3l ax3l disabled auto-merge April 30, 2024 22:49
@ax3l ax3l merged commit 2edabe8 into AMReX-Codes:development Apr 30, 2024
18 of 19 checks passed
@ax3l ax3l deleted the fix-isort-firstp branch April 30, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: tests tests and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant