Nmos receiver plugin #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LufeBisect
changed the base branch from
nmos-plugin-creation
to
feature-gstreamer-plugins
LufeBisect
force-pushed
the
nmos-receiver-plugin
branch
from
2c3c774 to
33699cd
Compare
dynamically changing pipelines
LufeBisect
force-pushed
the
nmos-receiver-plugin
branch
2 times, most recently
from
0e8f0ea to
56b4075
Compare
massis08
requested changes
Jan 23, 2025
cpp/libs/gst_nmos_plugins/src/gst_nmos_video_receiver_plugin.cpp
Outdated
Show resolved
Hide resolved
cpp/libs/gst_nmos_plugins/src/gst_nmos_video_receiver_plugin.cpp
Outdated
Show resolved
Hide resolved
cpp/libs/gst_nmos_plugins/src/gst_nmos_audio_receiver_plugin.cpp
Outdated
Show resolved
Hide resolved
cpp/libs/gst_nmos_plugins/src/gst_nmos_audio_receiver_plugin.cpp
Outdated
Show resolved
Hide resolved
cpp/libs/gst_nmos_plugins/src/gst_nmos_audio_receiver_plugin.cpp
Outdated
Show resolved
Hide resolved
cpp/libs/gst_nmos_plugins/src/gst_nmos_audio_receiver_plugin.cpp
Outdated
Show resolved
Hide resolved
LufeBisect
force-pushed
the
nmos-receiver-plugin
branch
3 times, most recently
from
e78fbc5 to
460f2cc
Compare
LufeBisect
force-pushed
the
nmos-receiver-plugin
branch
from
460f2cc to
04b289a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added nmos audio and video receiver as well as used classes to implement RAII design architecture so that resources are well freed at shutdown (changed in sender as well). Also made few small changes to the JSON configs to better represent the capabilities of each plugin when represented at the NMOS interface and changed all
gchar*tostd:stringfor better code maintainability.Usage example
Here are some example pipelines I used while testing
Video Sender:
Video Receiver:
Audio Sender:
Audio Receiver:
Notes
There's still some issues with the audio receiver with my tests, not being able to properly change between sources and needing to be changed back then changed to the new source to effectively make the change.
Also in the future it might be better to merge all utils files into a single one where all plugins can get their functions and data structures from a centralized and shared file, to reduce redundancy across the codebase.