Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soften the policy of deactivating IS-05 Senders/Receivers #805

Open
wants to merge 3 commits into
base: is-11
Choose a base branch
from

Conversation

N-Nagorny
Copy link
Collaborator

Fixes the tests that deactivate IS-05 Senders/Receivers that might lead to unintended consequences.

@alabou
Copy link

alabou commented May 1, 2023

What are those "unintended" consequences? On the opposite I think that deactivating only the senders that are IS-11 compliant may be the cause of such unintended consequences because the non IS-11 Senders and Receivers may cause side-effects to the IS-11 Sender and Receiver under test. It is much safer to disable all the Senders and Receivers of the device under test to prevent such side-effects.

@N-Nagorny
Copy link
Collaborator Author

Solution from the call.

Go through the list of IS-05 Senders/Receivers and turn them off one by one. If a Sender/Receiver failed to get inactive, check if it's an IS-11 Sender/Receiver. If it is, then return test.FAIL, if not, just fixate it. In the end of the loop, collect all the fails for non IS-11 Sender/Receivers and return test.WARNING with the corresponding warning message.

@N-Nagorny N-Nagorny changed the title Deactivate IS-11 Senders/Receivers instead of IS-05 ones Soften the policy of deactivating IS-05 Senders/Receivers May 29, 2023
@N-Nagorny
Copy link
Collaborator Author

@garethsb, could you please take a look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants