Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Set MacOS deployment target for wider compatibility #694

Closed
wants to merge 5 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP: Got to put conda stuff first
cookpa committed Aug 8, 2024
commit f48185e44a077f835319e63c4294a898995bea5f
16 changes: 9 additions & 7 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
@@ -109,6 +109,15 @@ jobs:
if: matrix.platform_id == 'win_amd64'
uses: ilammy/msvc-dev-cmd@v1

# conda to get libpng on Mac that is compatible with more OS versions
# brew install libpng has a mininum OS of 12
- name: Set up Conda
if: startsWith(matrix.os, 'macos-')
uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
python-version: ${{ matrix.python }}

- name: Install cibuildwheel
run: python -m pip install cibuildwheel==2.19.2 setuptools toml

@@ -132,13 +141,6 @@ jobs:
run: |
echo "MACOSX_DEPLOYMENT_TARGET=${{ matrix.macos_target }}" >> $GITHUB_ENV

# conda to get libpng on Mac that is compatible with more OS versions
# brew install libpng has a mininum OS of 12
- uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
python-version: ${{ matrix.python }}

- name: Build wheels
env:
CIBW_MANYLINUX_X86_64_IMAGE: manylinux2014