Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add geoip module support #66

Merged
merged 1 commit into from
Nov 5, 2015

Conversation

TinOo512
Copy link
Contributor

@TinOo512 TinOo512 commented Nov 3, 2015

#4

We moved the work of @welcoMattic (#46) in our organisation.

So this PR is now split and clean.

@farridav
Copy link

farridav commented Nov 3, 2015

Nice contribution! do we want to default this to on? its going to cause everyone using this role that is building from source to have to recompile their nginx installation (that includes me) or add nginx_geoip:·'off' into their playbooks

I suppose the bigger question here is do we want to add all new features into the nginx build by default @otakup0pe @soupdiver @pjan?

@otakup0pe
Copy link
Member

My preference is for the default behavior when adding (most) features is to remain the same. To that end, this (and other modules) should probably not be enabled by default.

@farridav
Copy link

farridav commented Nov 4, 2015

If we can get this feature disabled by default, happy to get it merged in :) separate to this, we will add a note to the README specifying the process for adding new features going forwards :)

@TinOo512
Copy link
Contributor Author

TinOo512 commented Nov 4, 2015

I renamed the key in the nginx_source_modules_included and I disabled the module by default.

But maybe we should remove it from nginx_source_modules_included because even if it's disable it will be include in the nginx build.

Also let me know if I should squash my commits :)

@farridav
Copy link

farridav commented Nov 5, 2015

I guess its ok to leave it in the source modules because anyone choosing to build from source, will probably be doing it so they can use their own compile flags within nginx_source_modules_included so will not be affected by this addition... squashing into the first commit would be awesome! keep the mainline clean... will keep a close eye on this and aim to get this in as soon as squashed.. thanks for your contribution :)

@TinOo512
Copy link
Contributor Author

TinOo512 commented Nov 5, 2015

Done :)

farridav pushed a commit that referenced this pull request Nov 5, 2015
@farridav farridav merged commit 6cc2a22 into ANXS:master Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants