Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all_zero cdf ctx: No need to clamp top and left #291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wantehchang
Copy link
Collaborator

My colleague Vignesh Venkatasubramanian suggested this change.

In the procedure for computing the 'ctx' variable for the all_zero cdf, the following two lines can be omitted:

    top = Min( top, 255 )
    left = Min( left, 255 )

'top' and 'left' are the maximum of AboveLevelContext[ plane ][ x4 + k ] and LeftLevelContext[ plane ][ y4 + k ], respectively. The value we store in AboveLevelContext and LeftLevelContext are less than or equal to 63, because of the following line in the coeffs( plane, startX, startY, txSz ) function in Section 5.11.39:

    culLevel = Min( 63, culLevel )

My colleague Vignesh Venkatasubramanian suggested this change.

In the procedure for computing the 'ctx' variable for the all_zero cdf, the following two lines can be omitted:

        top = Min( top, 255 )
        left = Min( left, 255 )

'top' and 'left' are the maximum of AboveLevelContext[ plane ][ x4 + k ] and LeftLevelContext[ plane ][ y4 + k ], respectively. The value we store in AboveLevelContext and LeftLevelContext are less than or equal to 63, because of the following line in the coeffs( plane, startX, startY, txSz ) function in Section 5.11.39:

        culLevel = Min( 63, culLevel )
@peterderivaz
Copy link
Collaborator

Good spot! This looks like a good simplification to me, but I don't know how much the working group want to modify the specification at this point.

I suggest you ask Adrian Grange if he wants it to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants