Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gsoc 2023 migrating main activity to compose #62

Conversation

narendraanjana09
Copy link
Contributor

@narendraanjana09 narendraanjana09 commented Aug 27, 2023

Fixes #61

Changes :

Migrated Main Activity to Compose, Added new Top App Bar, Bottom Nav Bar and fixed few bug fixes along it.

Previous UI:

image


New UI ScreenShot

image


New UI Screen recording:

https://drive.google.com/file/d/1cWChlhjyOEiJxzEtVAC4zJVvGf_dCDiW/view?usp=drivesdk


Appetize App Link

https://appetize.io/app/d7wqeezvl3ynuojmq2fgpxgow4?device=pixel4&osVersion=11.0&scale=75

@hackeramitkumar
Copy link
Member

@narendraanjana09 You have to resolve conflicts..

@narendraanjana09
Copy link
Contributor Author

@narendraanjana09 You have to resolve conflicts..
resolved.

@narendraanjana09 narendraanjana09 force-pushed the gsoc-2023_migrating_main_activity_to_compose branch from f7c7841 to 569b4d4 Compare August 31, 2023 07:01
@hackeramitkumar
Copy link
Member

@narendraanjana09 rebase it..

@narendraanjana09 narendraanjana09 force-pushed the gsoc-2023_migrating_main_activity_to_compose branch from 569b4d4 to 582e578 Compare September 1, 2023 03:01
@narendraanjana09
Copy link
Contributor Author

@narendraanjana09 rebase it..

done

@hackeramitkumar
Copy link
Member

@narendraanjana09 rebase it...

@narendraanjana09 narendraanjana09 force-pushed the gsoc-2023_migrating_main_activity_to_compose branch from 582e578 to 601348e Compare September 2, 2023 05:19
@narendraanjana09
Copy link
Contributor Author

@narendraanjana09 rebase it...

done

@hackeramitkumar
Copy link
Member

@narendraanjana09 this is our last pr for the jetpack compose migration. So now you have to fix the linting.

@hackeramitkumar
Copy link
Member

gradlew ktlintcheck -p

Run this command locally and fix the issues.

@narendraanjana09
Copy link
Contributor Author

gradlew ktlintcheck -p

Run this command locally and fix the issues.

I have tried it before but it seems to me that issue is not here actually out actions ci file is not able to read our secrets thus unable to assign values to variables in build file which leads to non-null error.

@hackeramitkumar hackeramitkumar merged commit bd212f8 into AOSSIE-Org:gsoc-2023 Sep 3, 2023
3 of 4 checks passed
hackeramitkumar added a commit that referenced this pull request Oct 17, 2023
* Updated version for various dependencies and made it compatible for compose,...

* added github action ci workflow file

* Update for some issue In Deploy to Appetize

* Migrated fragment_welcome.xml and fragment_intro.xml to compose under WelcomeScreen.kt (#11)

* Gsoc 2023 login screen migration to compose (#16)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_login.xml to LoginScreen.kt Compose and Updated
facebook Sdk version to latest and added code changes according to new
methods in doc and updated gitlab-ci.yml for fbClientSecret

* Gsoc 2023 signup screen compose migrartion (#17)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* SignUp fragment migration to jetpack compose

* Gsoc 2023 forgot password screen migration (#63)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Forgot Password Screen Migration to jetpack compose

* Gsoc 2023 migrating two factor auth fragment to compose (#19)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_two_factor_auth.xml to TwoFactorAuthScreen.kt in compose

* Gsoc 2023 home screen migrartion (#25)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_login.xml to LoginScreen.kt Compose and Updated
facebook Sdk version to latest and added code changes according to new
methods in doc and updated gitlab-ci.yml for fbClientSecret

* Migrated fragment_home.xml to HomeScreen.kt in compose

* Gsoc 2023 migrating elections fragment to compose (#31)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_elections.xml.xml to ElectionsScreen.kt in compose

* Gsoc 2023 migrating finished elections fragment to compose (#35)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_elections.xml.xml to ElectionsScreen.kt in compose

* Migrated fragment_finished_elections.xmle.xml.xml to ElectionsScreen.kt in compose

* Gsoc 2023 profile screen migration compose (#29)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_login.xml to LoginScreen.kt Compose and Updated
facebook Sdk version to latest and added code changes according to new
methods in doc and updated gitlab-ci.yml for fbClientSecret

* Migrated fragment_home.xml to HomeScreen.kt in compose

* Migrated fragment_settings.xml to SettingScreen.kt in Compose

* Migrated fragment_profile.xml to ProfileScreen.kt in compose

* Gsoc 2023 migrating active elections fragment to compose (#36)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_elections.xml.xml to ElectionsScreen.kt in compose

* Migrated fragment_finished_elections.xmle.xml.xml to ElectionsScreen.kt in compose

* Migrated fragment_active_elections.xml.xmle.xml.xml to ElectionsScreen.kt in compose

* Gsoc 2023 about us screen migration to compose (#44)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_about.xml to AboutScreen.kt.kt in Compose

* Gsoc 2023 share fragment migration to compose (#45)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_share_with_others.xml to ShareWithOthersScreen.kt in compose

* Gsoc 2023 contact us fragment migartion to compose (#46)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_contact_us.xml.xml to ContactUsScreen.kt in compose

* Gsoc 2023 migrating election details fragment to compose (#48)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_election_details.xml to ElectionDetailsScreen.kt in compose

* Gsoc 2023 settings screen migration compose (#27)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_login.xml to LoginScreen.kt Compose and Updated
facebook Sdk version to latest and added code changes according to new
methods in doc and updated gitlab-ci.yml for fbClientSecret

* Migrated fragment_home.xml to HomeScreen.kt in compose

* Migrated fragment_settings.xml to SettingScreen.kt in Compose

* Gsoc 2023 migrating pending elections fragment to compose (#37)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_elections.xml.xml to ElectionsScreen.kt in compose

* Migrated fragment_finished_elections.xmle.xml.xml to ElectionsScreen.kt in compose

* Migrated fragment_active_elections.xml.xmle.xml.xml to ElectionsScreen.kt in compose

* Migrated fragment_pending_elections.xml to ElectionsScreen.kt in compose

* Gsoc 2023 migrating calendar fragment to compose (#40)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_elections.xml.xml to ElectionsScreen.kt in compose

* Migrated fragment_calendar_view_election.xml to CalendarScreen.kt in compose

* Gsoc 2023 migrating voters list fragment to compose (#51)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_election_details.xml to ElectionDetailsScreen.kt in compose

* Migrated fragment_voters.xml.xml to VotersListScreen.kt in compose

* Gsoc 2023 migrating invite voters fragment (#60)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_invite_voters.xml to InviteVotersScreen.kt in compose

* Gsoc 2023 migrating ballot list fragment to compose (#52)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_election_details.xml to ElectionDetailsScreen.kt in compose

* Migrated fragment_ballot.xml to BallotsListScreen.kt in compose

* Migrated fragment_voters.xml.xml to VotersListScreen.kt in compose

* Migrated fragment_ballot.xml to BallotsListScreen.kt in compose

* Gsoc 2023 migrating cast vote activity to jetpack compose (#57)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated activity_cast_vote.xml to CastVoteActivity.kt in compose

* Gsoc 2023 migrating result fragment to compose (#58)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_result.xml to ResultScreen.kt in compose

* Gsoc 2023 migrating create elections fragment to compose (#59)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_create_election.xml to CreateElectionsScreen.kt in compose

* Gsoc 2023 migrating main activity to compose (#62)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Migrated fragment_invite_voters.xml to InviteVotersScreen.kt in compose

* Migrated fragment_voters.xml.xml to VotersListScreen.kt in compose

* Migrated fragment_finished_elections.xmle.xml.xml to ElectionsScreen.kt in compose

* Forgot Password Screen Migration to jetpack compose

* Migrated fragment_two_factor_auth.xml to TwoFactorAuthScreen.kt in compose

* Migrated fragment_login.xml to LoginScreen.kt Compose and Updated
facebook Sdk version to latest and added code changes according to new
methods in doc and updated gitlab-ci.yml for fbClientSecret

* Migrated fragment_home.xml to HomeScreen.kt in compose

* Migrated fragment_settings.xml to SettingScreen.kt in Compose

* Updated Main Activity parts to use Compose

* Gsoc 2023 update report (#66)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* updated report for GSoC 2023

* Gsoc 2023 Updated readme.md file with new screenshots (#68)

* Update for some issue In Deploy to Appetize

* removed Github Token from ci file

* Updated Screenshots for new UI in the README.md file and also update contributing.md file link

---------

Co-authored-by: Narendra Singh Anjana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants