Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Dynamic imports and hardhat scripts #4

Conversation

Ronnieraj37
Copy link
Contributor

@Ronnieraj37 Ronnieraj37 commented Jan 26, 2024

Description

I've implemented and fixed all the issues mentioned below

  • Fixed Wrong Imports in solidity file
  • Dynamic Imports in front end
  • Changed scripts initializing the Authentication.sol and electionFactory.sol
  • Removed cache from serve/cache

Fixes #3

Type of change

Please mark the options that are relevant.

  • Updated UI/UX
  • Improved the business logic of code
  • Added new feature
  • Other

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Ronnieraj37
Copy link
Contributor Author

@harsh-mr I've edited all the changes and also removed the unnecessary blockchainBuilds & Builds folder from client/ . Do let me know if i missed something out

@harsh-mr
Copy link
Collaborator

harsh-mr commented Feb 21, 2024

Create a video of working soln and add as a comment

@Ronnieraj37
Copy link
Contributor Author

Ronnieraj37 commented Feb 21, 2024

Video Link - https://www.youtube.com/watch?v=F5JLcrJ6We0
(Can skip 1:50 to 2:40 as this just explains the uninitialised diamond contract)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants