Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove hardcoded aws region #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Samama251251
Copy link

Summary

This pull request refactors the authentication controller to use the AWS region specified in the configuration file (config.prod.yml) instead of a hardcoded value. This change enhances the flexibility and configurability of the application, allowing it to adapt to different deployment environments without code changes.

Changes

  • Updated functions in auth.go to load AWS configuration using the region from the config file.
  • Fixed a typo in the config.go file where the openai struct's YAML tag was missing a closing quote.

Testing

  • Verified that the application correctly loads the AWS region from the configuration file.
  • Ensured that all authentication-related functionalities (sign-up, login, password reset, etc.) work as expected with the updated configuration.

Additional Notes

  • This change requires the config.prod.yml file to have the correct AWS region specified under the cognito section.

@Samama251251
Copy link
Author

Samama251251 commented Mar 6, 2025

Currently in functions of the auth controller aws reigon is hardcoded. In my pull request I have removed these harcode reigons and configured them to be used from config.prod.yml file
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant