Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented new features #6

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Pranav0-0Aggarwal
Copy link
Member

Implemented features like:

  1. Retrieve all rooms data
  2. Retrieve data of single room
  3. Retrieve data of a user.

added installation instructions.
updated readme with installation instructions, contact details , for welcoming open source enthusiasts interested in this project.
Added License file
Rooms endpoint to retrieve rooms info.
room endpoint to retrieve single room info
user id endpoint to retrieve user info based on id.
Copy link
Member

@chandansgowda chandansgowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing I would like to add is that the commit structure is not maintained as required. Refer to README in main repo. I would suggest you do this as of now - Drop this PR and create a new branch and just get the README file edited. Once the firebase structure is finalized, you can work on the endpoints.

README.md Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, retrieving room details will happen directly through the app. Also Firebase Firestore Structure has not yet been finalized. Please remove this file until that's done. You can join the discussion in the related issue posted on Resonate repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, got that, are there any other required routes that I can design?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants