-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented new features #6
base: main
Are you sure you want to change the base?
Conversation
added installation instructions.
updated readme with installation instructions, contact details , for welcoming open source enthusiasts interested in this project.
Added License file
Rooms endpoint to retrieve rooms info. room endpoint to retrieve single room info user id endpoint to retrieve user info based on id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing I would like to add is that the commit structure is not maintained as required. Refer to README in main repo. I would suggest you do this as of now - Drop this PR and create a new branch and just get the README file edited. Once the firebase structure is finalized, you can work on the endpoints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, retrieving room details will happen directly through the app. Also Firebase Firestore Structure has not yet been finalized. Please remove this file until that's done. You can join the discussion in the related issue posted on Resonate repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, got that, are there any other required routes that I can design?
Implemented features like: