-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update : added forced app update #226
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refactor the project. This logic cannot be put inside login screen. Create a utility function or a separate controller if required.
@chandansgowda , so should i put it at the beginning when the app just starts ? or where do you suggest to put it ? |
I meant, the code has to be refactored. |
@chandansgowda I have refactored the code and moved the logic to controllers, please review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimardeepSingh1450 I see that there are a lot of code quality guidelines to be met. Refer to dart's coding convention and update the PR.
@chandansgowda made the changes please re-review |
@chandansgowda , sorry for the delay, but I have resolved the conflicts on the branch and can be merged now 👍 |
Hey @SimardeepSingh1450 please do the requested changes, or explain the reason for leaving it hard coded. Resolve the conflicts to bring the PR in a stable state will merge once required changes are made |
@SimardeepSingh1450 please do the requested changes, asap and revet back please |
Description
Added forced app update prompt so so as to prompt the users to force update the app when their app goes below a minimum version.
How it works ?
Conditionally render the login screen only after the minimum version check has been passed using the future-builder widget, but if check is not passed then a prompt pops up which asks the user to first update the app and then use it.
Fixes #217
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Locally tested this app on my android device and tested the new changes as well.
Checklist:
Maintainer Checklist