Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : handle Network image load Exception in discussion tile #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kareemabdeen
Copy link
Contributor

@kareemabdeen kareemabdeen commented Mar 15, 2024

Description

image of the user in discussion tile throw an Network Image Load Exception while user where scrolling

Fixes #300

Type of change

add on Foreground Image Error attribute to catch error throwing when loading user image

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

with my emulator

Please include screenshots below if applicable.
exception thrown while user scrolling
Screenshot (1638)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

@kareemabdeen
Copy link
Contributor Author

kareemabdeen commented Mar 15, 2024

@chandansgowda Please review

@kareemabdeen
Copy link
Contributor Author

@chandansgowda if there's any problem on the branch please let me know

@Aarush-Acharya
Copy link
Contributor

Hey @kareemabdeen I tried scrolling multiple times, I do not see any error can you please elaborate on steps of reproduction of the error

@Aarush-Acharya Aarush-Acharya added attended This PR was attended by a Reviewer intra awaitIntra and removed intra labels May 10, 2024
@AyaNady17
Copy link
Contributor

AyaNady17 commented May 15, 2024

Hey @kareemabdeen I tried scrolling multiple times, I do not see any error can you please elaborate on steps of reproduction of the error

It only appears with discussion item created by user who has a custom profile picture so simply do the following
Login to the app
Custom ur profile picture
Schedule a call to appear on discussion list
Go to discussion tap and find ur discussion tile with the custom photo
Observe
@Aarush-Acharya

@vrundraval24
Copy link
Contributor

vrundraval24 commented May 23, 2024

@AyaNady17 hey I am also unable to reproduce the issue. @Aarush-Acharya what about you??

@Aarush-Acharya
Copy link
Contributor

Hey @AyaNady17 @vrundraval24 will do so give me some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attended This PR was attended by a Reviewer awaitIntra
Projects
None yet
4 participants