Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added type annotations #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added type annotations #65

wants to merge 1 commit into from

Conversation

joamatab
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #65 (1664a18) into master (c93ef2d) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   92.61%   92.76%   +0.14%     
==========================================
  Files          25       25              
  Lines        1314     1340      +26     
==========================================
+ Hits         1217     1243      +26     
  Misses         97       97              
Impacted Files Coverage Δ
aotools/astronomy/_astronomy.py 100.00% <100.00%> (ø)
aotools/fouriertransform.py 77.77% <100.00%> (+0.85%) ⬆️
aotools/functions/_functions.py 100.00% <100.00%> (ø)
aotools/functions/karhunenLoeve.py 92.64% <100.00%> (+0.06%) ⬆️
aotools/functions/pupil.py 94.11% <100.00%> (+0.78%) ⬆️
aotools/functions/zernike.py 96.94% <100.00%> (+0.04%) ⬆️
aotools/image_processing/centroiders.py 100.00% <100.00%> (ø)
aotools/image_processing/contrast.py 100.00% <100.00%> (ø)
aotools/image_processing/psf.py 100.00% <100.00%> (ø)
aotools/interpolation.py 91.22% <100.00%> (+0.31%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93ef2d...1664a18. Read the comment docs.

@matthewtownson matthewtownson self-assigned this Mar 18, 2022
@matthewtownson
Copy link
Member

Sorry for ignoring this, we completely forgot and only realised when we came to clean through the open issues and PRs. Is there any chance you could pull the current version of the code in to resolve the conflicts, then I will accept this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants