Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make waterlogged blocks count as water. #519

Open
goodroach opened this issue May 14, 2022 · 2 comments · May be fixed by #704
Open

Make waterlogged blocks count as water. #519

goodroach opened this issue May 14, 2022 · 2 comments · May be fixed by #704
Labels
enhancement

Comments

@goodroach
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Make it so water logged blocks gets checked as water and the slab at the same time. This edge case is to prevent water armor, since currently the waterlogged blocks do not get counted when the ship is checking for water.
@MegalithOfficial
Copy link

I guess its not checking is it waterlogged or not

@TylerS1066 TylerS1066 moved this to New in Issue Triage May 22, 2022
@TylerS1066 TylerS1066 moved this from New to In Discussion in Issue Triage May 22, 2022
@TylerS1066
Copy link
Contributor

Upon some further discussion, I think it's best if we add a separate craft flag for maximum water (or possibly maximum liquid) rather than add an edge case that interprets waterlogged as water.

@TylerS1066 TylerS1066 moved this from In Discussion to Ready for Work in Issue Triage Jul 28, 2024
@Intybyte Intybyte linked a pull request Aug 26, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Issue Triage
Status: Ready for Work
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/watertagged Intybyte/Movecraft-fixes
3 participants
@TylerS1066 @goodroach @MegalithOfficial