-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature / Cleanup] Sign rework (WIP) #679
base: main
Are you sure you want to change the base?
Conversation
This would be best left for a separate PR. I believe there are many assumptions that Subcrafts never move, so we'll have to do a through review of the codebase for that feature. |
Alright, i will remove that from the todo list. Will implement the other points nonetheless |
it is a bit ugly to register it twice but i think that's just alright. Alternatively we could just create a empty sign change listener for the [Helm] stuff and roll with that
…t the craft that the sign is on
…again (cherry picked from commit a307803)
(cherry picked from commit 7075208)
…puteIfAbsent (cherry picked from commit e8896a2)
…d too (cherry picked from commit 039756d)
(cherry picked from commit 956053d)
(cherry picked from commit 9a40431)
(cherry picked from commit 232ab10)
(cherry picked from commit 91ff872)
(cherry picked from commit 3f8dfdb)
(cherry picked from commit 633f33c)
(cherry picked from commit 3aa0dc9)
(cherry picked from commit 5e0ed2e)
(cherry picked from commit 88baa63)
(cherry picked from commit 1853ba7)
(cherry picked from commit 2316876)
(cherry picked from commit 238e989)
Describe in detail what your pull request accomplishes
This PR is a attempt at redoing signs in a more organized way.
That encompasses the following things:
TODO List:
[ ] NEW Subcraft MovePostpone for later, this requires thorough analysis priorChecklist