Feature/track move flyblocks #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aren't there methods already in place that do that? Try checking the code for the status sign for an idea of how this works. Edit: There isn't but it seems you made it easier to access. I'm not sure if this is the correct way to do it, considering that someone might add a different set of blocks required for the craft. I think these implementations should be up to the programmer making the add-on. |
TylerS1066
requested changes
Aug 24, 2024
Movecraft/src/main/java/net/countercraft/movecraft/features/status/StatusManager.java
Outdated
Show resolved
Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/features/status/StatusManager.java
Outdated
Show resolved
Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/features/status/StatusManager.java
Outdated
Show resolved
Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/features/status/StatusSign.java
Outdated
Show resolved
Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/features/status/StatusSign.java
Outdated
Show resolved
Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/features/status/StatusSign.java
Outdated
Show resolved
Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/features/status/StatusSign.java
Outdated
Show resolved
Hide resolved
|
Tested and working well! |
TylerS1066
requested changes
Aug 25, 2024
TylerS1066
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail what your pull request accomplishes
Add craft methods to get:
Move Block Amount
Flyblock Amount
Related issues:
#678
Checklist