Feature/sink explosion #701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerS1066
reviewed
Aug 25, 2024
Comment on lines
+213
to
+227
| @Override | ||
| public void run() { | ||
| CraftType type = sinkingCraft.getType(); | ||
| float explosionStrength = type.getFloatProperty(CraftType.EXPLODE_ON_SINK); | ||
| boolean incendiary = type.getBoolProperty(CraftType.INCENDIARY_ON_SINK); | ||
|
|
||
| Location location = sinkingCraft.getHitBox().getMidPoint().toBukkit(sinkingCraft.getWorld()); | ||
|
|
||
| ExplosionEvent event = new ExplosionEvent(location, explosionStrength, incendiary); | ||
| Bukkit.getServer().getPluginManager().callEvent(event); | ||
|
|
||
| if (!event.isCancelled()) | ||
| location.createExplosion(explosionStrength, incendiary); | ||
| } | ||
| }.runTaskLater(Movecraft.getInstance(), tickDelay); |
There was a problem hiding this comment.
This implementation does not match the requested feature in #501. The request was that blocks randomly explode as the craft sinks, this triggers a single explosion at the center.
There was a problem hiding this comment.
My bad went by assumption, and didnt finish reading, my idea was that if like when a player dies/craft sinks or a craft sinks it explodes so it can't be used by the enemy or for modern servers that use movecraft and are like OilTrucks or stuff that in general can carry dangerous stuff they explode on sink
There was a problem hiding this comment.
this is too different from the feature in #501, if this features isn't needed I will close it, otherwise I will close the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail what your pull request accomplishes
Adds the ability to make the craft explode on sink
Related issues:
Checklist