Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation performance #710

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Rotation performance #710

merged 6 commits into from
Sep 5, 2024

Conversation

TylerS1066
Copy link
Contributor

@TylerS1066 TylerS1066 commented Sep 5, 2024

This PR supersedes and will close #708 solely because I can not push to it.

@TylerS1066 TylerS1066 requested a review from oh-noey September 5, 2024 16:55
@TylerS1066 TylerS1066 marked this pull request as ready for review September 5, 2024 17:08
@TylerS1066
Copy link
Contributor Author

Performance tested, a Shadow of the Deep refit 2 (~17,000 sub) used to rotate in ~160ms, now it rotates in ~90ms.

@TylerS1066
Copy link
Contributor Author

Using the last build and 1ms spark intervals (/spark profiler start --thread * --interval 1), the performance improvement is from above 2x, going from 50-60ms to <25ms.

@TylerS1066 TylerS1066 merged commit 45e1261 into main Sep 5, 2024
2 checks passed
@TylerS1066 TylerS1066 deleted the rotation-performance branch September 5, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants