[Bugfix] Fix infinite loop in TranslationTask #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intybyte
approved these changes
Dec 8, 2024
TylerS1066
requested changes
Dec 14, 2024
Movecraft/src/main/java/net/countercraft/movecraft/async/translation/TranslationTask.java
Outdated
Show resolved
Hide resolved
| test = test.translate(0, -1, 0); | ||
| } | ||
| Material testType = test.toBukkit(world).getBlock().getType(); | ||
| if (craft.getType().getMaterialSetProperty(CraftType.FORBIDDEN_HOVER_OVER_BLOCKS).contains(testType)) { | ||
| // Why is there no return here? Shouldnt there be one? |
There was a problem hiding this comment.
No need for this comment
There was a problem hiding this comment.
It is a serious question i have there.
There was a problem hiding this comment.
Ok, it seems i confused the lines when i wrote that comment, but anyway. Once the craft goes over a forbidden hover over block, it can't translate at all. Calling fail also pretty much implies that the result is final at that point, but yet the function would continue, so the return is necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail what your pull request accomplishes
There is a infinite loop in TranslationTask.java in the validation for forbidden hover blocks. In short, the position moves out of worldspace and thus the returned block will always be air, resulting in a infinite loop.
Also fixed a probably missing return statement further down, if a block was found that can't be hovered over
Related issues:
Checklist