Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: xml skill: treat all="0" as no "all" #70

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix bug: xml skill: treat all="0" as no "all" #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xml.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ void parse_card_node(Cards& all_cards, Card* card, xml_node<>* card_node)
auto c = node_value(skill_node, "c", skill_id==Skill::flurry?1:0);
auto s = skill_target_skill(skill_node, "s");
auto s2 = skill_target_skill(skill_node, "s2");
bool all = skill_node->first_attribute("all");
bool all = node_value(skill_node, "all", 0);
auto card_id = node_value(skill_node, "card_id", 0);
//scaling
if(abs(1-x_skill_scale[Skill::no_skill]*x_skill_scale[skill_id==Skill::enhance?s:skill_id])>eps)
Expand Down Expand Up @@ -502,7 +502,7 @@ Deck* read_deck(Decks& decks, const Cards& all_cards, xml_node<>* node, DeckType
auto c = node_value(skill_node, "c", 0);
auto s = skill_target_skill(skill_node, "s");
auto s2 = skill_target_skill(skill_node, "s2");
bool all(skill_node->first_attribute("all"));
bool all(node_value(skill_node, "all", 0));
effects.push_back({skill_id, x, y, n, c, s, s2, all});
}
}
Expand Down
Loading