Rename the browser to client

ARCANEDEV · Aug 30, 2020 · 71bbdef · 71bbdef
1 parent ad3d017
commit 71bbdef
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 18 deletions.
diff --git a/src/Detectors/DeviceDetector.php b/src/Detectors/DeviceDetector.php
@@ -85,31 +85,31 @@ public function osVersion(): string
     }
 
     /**
-     * Get the browser name.
+     * Get the client name.
      *
      * @return string
      */
-    public function browserName()
+    public function clientName()
     {
         return $this->getClient('name');
     }
 
     /**
-     * Get the browser name.
+     * Get the client name.
      *
      * @return string
      */
-    public function browserShortName()
+    public function clientShortName()
     {
         return $this->getClient('short_name');
     }
 
     /**
-     * Get the browser's version.
+     * Get the client's version.
      *
      * @return string
      */
-    public function browserVersion(): string
+    public function clientVersion(): string
     {
         return $this->getClient('version');
     }
@@ -140,17 +140,17 @@ public function isVisitor(): bool
      */
 
     /**
-     * Check the given name matches browser's name.
+     * Check the given name matches client's name.
      *
      * @param  string  $name
      *
      * @return bool
      */
-    public function isBrowserName($name): bool
+    public function isClientName($name): bool
     {
         return in_array($name, [
-            $this->browserName(),
-            $this->browserShortName(),
+            $this->clientName(),
+            $this->clientShortName(),
         ]);
     }
 

diff --git a/tests/AgentTest.php b/tests/AgentTest.php
@@ -112,17 +112,17 @@ public function it_can_get_languages_sorted(): void
      * @dataProvider  provideBrowsersData
      *
      * @param  string  $userAgent
-     * @param  array   $browser
+     * @param  array   $client
      */
-    public function it_can_check_browsers(string $userAgent, array $browser): void
+    public function it_can_check_client(string $userAgent, array $client): void
     {
         $device = $this->parseDevice($userAgent);
 
-        static::assertEquals($browser['name'], $device->browserName(), $userAgent);
-        static::assertEquals($browser['short_name'], $device->browserShortName(), $userAgent);
+        static::assertEquals($client['name'], $device->clientName(), $userAgent);
+        static::assertEquals($client['short_name'], $device->clientShortName(), $userAgent);
 
-        static::assertTrue($device->isBrowserName($browser['name']), $userAgent);
-        static::assertTrue($device->isBrowserName($browser['short_name']), $userAgent);
+        static::assertTrue($device->isClientName($client['name']), $userAgent);
+        static::assertTrue($device->isClientName($client['short_name']), $userAgent);
     }
 
     /**
@@ -133,11 +133,11 @@ public function it_can_check_browsers(string $userAgent, array $browser): void
      * @param  string  $userAgent
      * @param  string  $version
      */
-    public function it_can_get_browser_version(string $userAgent, string $version): void
+    public function it_can_get_client_version(string $userAgent, string $version): void
     {
         $device = $this->parseDevice($userAgent);
 
-        static::assertEquals($version, $device->browserVersion(), $userAgent);
+        static::assertEquals($version, $device->clientVersion(), $userAgent);
     }
 
     /**