Simplify the detectors' parsing

ARCANEDEV · Nov 30, 2020 · 956bc7c · 956bc7c
1 parent af15ca3
commit 956bc7c
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/src/Detectors/DeviceDetector.php b/src/Detectors/DeviceDetector.php
@@ -39,8 +39,20 @@ class DeviceDetector implements Detector
      */
     public function handle(Request $request): Detector
     {
-        $userAgent = $request->server('HTTP_USER_AGENT');
+        return $this->fromUserAgent(
+            $request->server('HTTP_USER_AGENT')
+        );
+    }
 
+    /**
+     * Handle from the given user agent.
+     *
+     * @param  string  $userAgent
+     *
+     * @return $this
+     */
+    public function fromUserAgent(string $userAgent): Detector
+    {
         $this->detector = tap(new BaseDetector($userAgent), function (BaseDetector $detector) {
             $detector->parse();
         });

diff --git a/src/Detectors/LanguageDetector.php b/src/Detectors/LanguageDetector.php
@@ -62,9 +62,22 @@ public function keys(): array
      * @return $this
      */
     public function handle(Request $request): Detector
+    {
+        return $this->fromAcceptLanguage(
+            $request->server('HTTP_ACCEPT_LANGUAGE')
+        );
+    }
+
+    /**
+     * Handle from the given accept language.
+     *
+     * @param  string  $acceptLanguage
+     *
+     * @return $this
+     */
+    public function fromAcceptLanguage(string $acceptLanguage): Detector
     {
         $this->languages = [];
-        $acceptLanguage  = $request->server('HTTP_ACCEPT_LANGUAGE');
 
         if ( ! empty($acceptLanguage)) {
             $this->parse($acceptLanguage);