Merge pull request #23 from ARCANEDEV/update-laravel_5.8

Adding Laravel 5.8 support
ARCANEDEV · Feb 28, 2019 · 6d8dfdd · 6d8dfdd
2 parents 18b24cb + 0ee29c9
commit 6d8dfdd
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 30 deletions.
diff --git a/LICENSE.md b/LICENSE.md
@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2016-2018 | ARCANEDEV <[email protected]> - Laravel Notes
+Copyright (c) 2016-2019 | ARCANEDEV <[email protected]> - Laravel Notes
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

diff --git a/README.md b/README.md
@@ -20,7 +20,7 @@ This Laravel Notes will allow you to add a notes system into your Laravel projec
   * Easy setup &amp; configuration.
   * Well documented &amp; IDE Friendly.
   * Well tested with maximum code quality.
-  * Laravel `5.1` to `5.7` are supported.
+  * Laravel `5.1` to `5.8` are supported.
   * Made with :heart: &amp; :coffee:.
 
 ## Table of contents
@@ -42,7 +42,7 @@ If you discover any security related issues, please email arcanedev.maroc@gmail.
   - [ARCANEDEV][link-author]
   - [All Contributors][link-contributors]
 
-[badge_laravel]:      https://img.shields.io/badge/For%20Laravel-5.1%20to%205.7-orange.svg?style=flat-square
+[badge_laravel]:      https://img.shields.io/badge/For%20Laravel-5.1%20to%205.8-orange.svg?style=flat-square
 [badge_license]:      https://img.shields.io/packagist/l/arcanedev/laravel-notes.svg?style=flat-square
 [badge_build]:        https://img.shields.io/travis/ARCANEDEV/LaravelNotes.svg?style=flat-square
 [badge_coverage]:     https://img.shields.io/scrutinizer/coverage/g/ARCANEDEV/LaravelNotes.svg?style=flat-square

diff --git a/_docs/0-Home.md b/_docs/0-Home.md
@@ -8,7 +8,7 @@ This Laravel Notes will allow you to add a notes system into your Laravel projec
   * Easy setup &amp; configuration.
   * Well documented &amp; IDE Friendly.
   * Well tested with maximum code quality.
-  * Laravel `5.1` to `5.7` are supported.
+  * Laravel `5.1` to `5.8` are supported.
   * Made with :heart: &amp; :coffee:.
 
 ## Table of contents

diff --git a/_docs/1-Installation-and-Setup.md b/_docs/1-Installation-and-Setup.md
@@ -23,6 +23,7 @@ The Laravel Notes package has a few system requirements:
 | ![Laravel Notes v2.x][laravel_notes_2_x] | ![Laravel v5.5][laravel_5_5]                                                           |
 | ![Laravel Notes v3.x][laravel_notes_3_x] | ![Laravel v5.6][laravel_5_6]                                                           |
 | ![Laravel Notes v4.x][laravel_notes_4_x] | ![Laravel v5.7][laravel_5_7]                                                           |
+| ![Laravel Notes v5.x][laravel_notes_5_x] | ![Laravel v5.8][laravel_5_8]                                                           |
 
 [laravel_5_1]:  https://img.shields.io/badge/v5.1-supported-brightgreen.svg?style=flat-square "Laravel v5.1"
 [laravel_5_2]:  https://img.shields.io/badge/v5.2-supported-brightgreen.svg?style=flat-square "Laravel v5.2"
@@ -31,12 +32,14 @@ The Laravel Notes package has a few system requirements:
 [laravel_5_5]:  https://img.shields.io/badge/v5.5-supported-brightgreen.svg?style=flat-square "Laravel v5.5"
 [laravel_5_6]:  https://img.shields.io/badge/v5.6-supported-brightgreen.svg?style=flat-square "Laravel v5.6"
 [laravel_5_7]:  https://img.shields.io/badge/v5.7-supported-brightgreen.svg?style=flat-square "Laravel v5.7"
+[laravel_5_8]:  https://img.shields.io/badge/v5.8-supported-brightgreen.svg?style=flat-square "Laravel v5.8"
 
 [laravel_notes_0_x]: https://img.shields.io/badge/version-0.*-blue.svg?style=flat-square "LaravelNotes v0.*"
 [laravel_notes_1_x]: https://img.shields.io/badge/version-1.*-blue.svg?style=flat-square "LaravelNotes v1.*"
 [laravel_notes_2_x]: https://img.shields.io/badge/version-2.*-blue.svg?style=flat-square "LaravelNotes v2.*"
 [laravel_notes_3_x]: https://img.shields.io/badge/version-3.*-blue.svg?style=flat-square "LaravelNotes v3.*"
 [laravel_notes_4_x]: https://img.shields.io/badge/version-4.*-blue.svg?style=flat-square "LaravelNotes v4.*"
+[laravel_notes_5_x]: https://img.shields.io/badge/version-5.*-blue.svg?style=flat-square "LaravelNotes v5.*"
 
 ## Composer
 

diff --git a/composer.json b/composer.json
@@ -15,13 +15,13 @@
     "license": "MIT",
     "require": {
         "php":               ">=7.1.3",
-        "arcanedev/support": "~4.4.0"
+        "arcanedev/support": "~4.5.0"
     },
     "require-dev": {
-        "orchestra/testbench": "~3.7.0",
+        "orchestra/testbench": "~3.8.0",
         "mockery/mockery":     "~1.0",
-        "phpunit/phpunit":     "~7.0",
-        "phpunit/phpcov":      "~5.0"
+        "phpunit/phpunit":     "~7.0|~8.0",
+        "phpunit/phpcov":      "~5.0|~6.0"
     },
     "autoload": {
         "psr-4": {

diff --git a/tests/LaravelNotesServiceProviderTest.php b/tests/LaravelNotesServiceProviderTest.php
@@ -23,14 +23,14 @@ class LaravelNotesServiceProviderTest extends TestCase
      | -----------------------------------------------------------------
      */
 
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 
         $this->provider = $this->app->getProvider(LaravelNotesServiceProvider::class);
     }
 
-    public function tearDown()
+    public function tearDown(): void
     {
         unset($this->provider);
 
@@ -49,7 +49,7 @@ public function it_can_be_instantiated()
             \Illuminate\Support\ServiceProvider::class,
             \Arcanedev\Support\ServiceProvider::class,
             \Arcanedev\Support\PackageServiceProvider::class,
-            \Arcanedev\LaravelNotes\LaravelNotesServiceProvider::class,
+            LaravelNotesServiceProvider::class,
         ];
 
         foreach ($expectations as $expected) {

diff --git a/tests/Models/NoteTest.php b/tests/Models/NoteTest.php
@@ -14,10 +14,12 @@
  */
 class NoteTest extends TestCase
 {
-    /* ------------------------------------------------------------------------------------------------
-     |  Has One Note Tests
-     | ------------------------------------------------------------------------------------------------
+
+    /* -----------------------------------------------------------------
+     |  Tests [Has One Note]
+     | -----------------------------------------------------------------
      */
+
     /** @test */
     public function it_can_create_a_note()
     {
@@ -129,7 +131,7 @@ public function it_can_reverse_relation()
     }
 
     /* -----------------------------------------------------------------
-     |  Has Many Notes Tests
+     |  [Tests] Has Many Notes
      | -----------------------------------------------------------------
      */
 

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -24,7 +24,7 @@ abstract class TestCase extends BaseTestCase
      | -----------------------------------------------------------------
      */
 
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 
@@ -46,20 +46,6 @@ protected function getPackageProviders($app)
         ];
     }
 
-    /**
-     * Get package aliases.
-     *
-     * @param  \Illuminate\Foundation\Application  $app
-     *
-     * @return array
-     */
-    protected function getPackageAliases($app)
-    {
-        return [
-            //
-        ];
-    }
-
     /**
      * Define environment setup.
      *