Skip to content

Commit

Permalink
Adding Laravel 5.8 support (#21)
Browse files Browse the repository at this point in the history
* Update composer.json

* Adding Laravel 5.8 support

* Validate composer

* Return void in tests

* Add PhpUnit support

* Update composer versions

* Update LICENSE
  • Loading branch information
rcovar00 authored and arcanedev-maroc committed Mar 7, 2019
1 parent 41cb173 commit b6c43bf
Showing 10 changed files with 21 additions and 18 deletions.
2 changes: 1 addition & 1 deletion LICENSE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2017-2018 | ARCANEDEV <[email protected]> - LaravelImpersonator
Copyright (c) 2017-2019 | ARCANEDEV <[email protected]> - LaravelImpersonator

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ Feel free to check out the [releases](https://github.com/ARCANEDEV/LaravelSettin

### Features

* Laravel `5.2` to `5.7` are supported.
* Laravel `5.2` to `5.8` are supported.
* Multiple store drivers: `array`, `json`, `database`, `redis`.
* Easy setup &amp; configuration.
* Well documented &amp; IDE Friendly.
@@ -45,7 +45,7 @@ Any ideas are welcome. Feel free to submit any issues or pull requests, please c
- [All Contributors][link-contributors]

[badge_license]: https://img.shields.io/packagist/l/arcanedev/laravel-settings.svg?style=flat-square
[badge_laravel]: https://img.shields.io/badge/Laravel-5.2%20to%205.7-orange.svg?style=flat-square
[badge_laravel]: https://img.shields.io/badge/Laravel-5.2%20to%205.8-orange.svg?style=flat-square
[badge_build]: https://img.shields.io/travis/ARCANEDEV/LaravelSettings.svg?style=flat-square
[badge_coverage]: https://img.shields.io/scrutinizer/coverage/g/ARCANEDEV/LaravelSettings.svg?style=flat-square
[badge_quality]: https://img.shields.io/scrutinizer/g/ARCANEDEV/LaravelSettings.svg?style=flat-square
2 changes: 1 addition & 1 deletion _docs/0-Home.md
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ Feel free to check out the [releases](https://github.com/ARCANEDEV/LaravelSettin

### Features

* Laravel `5.2` to `5.7` are supported.
* Laravel `5.2` to `5.8` are supported.
* Multiple store drivers: `array`, `json`, `database`, `redis`.
* Easy setup &amp; configuration.
* Well documented &amp; IDE Friendly.
7 changes: 5 additions & 2 deletions _docs/1-Installation-and-Setup.md
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@
1. [Installation and Setup](1-Installation-and-Setup.md)
2. [Configuration](2-Configuration.md)
3. [Usage](3-Usage.md)

## Server Requirements

The LaravelSettings package has a few system requirements:
@@ -21,23 +21,26 @@ The LaravelSettings package has a few system requirements:
| ![LaravelSettings v2.x][laravel_settings_2_x] | ![Laravel v5.5][laravel_5_5] |
| ![LaravelSettings v3.x][laravel_settings_3_x] | ![Laravel v5.6][laravel_5_6] |
| ![LaravelSettings v4.x][laravel_settings_4_x] | ![Laravel v5.7][laravel_5_7] |
| ![LaravelSettings v5.x][laravel_settings_5_x] | ![Laravel v5.8][laravel_5_8] |

[laravel_5_2]: https://img.shields.io/badge/v5.2-supported-brightgreen.svg?style=flat-square "Laravel v5.2"
[laravel_5_3]: https://img.shields.io/badge/v5.3-supported-brightgreen.svg?style=flat-square "Laravel v5.3"
[laravel_5_4]: https://img.shields.io/badge/v5.4-supported-brightgreen.svg?style=flat-square "Laravel v5.4"
[laravel_5_5]: https://img.shields.io/badge/v5.5-supported-brightgreen.svg?style=flat-square "Laravel v5.5"
[laravel_5_6]: https://img.shields.io/badge/v5.6-supported-brightgreen.svg?style=flat-square "Laravel v5.6"
[laravel_5_7]: https://img.shields.io/badge/v5.7-supported-brightgreen.svg?style=flat-square "Laravel v5.7"
[laravel_5_8]: https://img.shields.io/badge/v5.8-supported-brightgreen.svg?style=flat-square "Laravel v5.8"

[laravel_settings_0_x]: https://img.shields.io/badge/version-0.*-blue.svg?style=flat-square "LaravelSettings v0.*"
[laravel_settings_1_x]: https://img.shields.io/badge/version-1.*-blue.svg?style=flat-square "LaravelSettings v1.*"
[laravel_settings_2_x]: https://img.shields.io/badge/version-2.*-blue.svg?style=flat-square "LaravelSettings v2.*"
[laravel_settings_3_x]: https://img.shields.io/badge/version-3.*-blue.svg?style=flat-square "LaravelSettings v3.*"
[laravel_settings_4_x]: https://img.shields.io/badge/version-4.*-blue.svg?style=flat-square "LaravelSettings v4.*"
[laravel_settings_5_x]: https://img.shields.io/badge/version-5.*-blue.svg?style=flat-square "LaravelSettings v5.*"

## Composer

You can install this package via [Composer](http://getcomposer.org/) by running this command:
You can install this package via [Composer](http://getcomposer.org/) by running this command:

```bash
composer require arcanedev/laravel-settings
10 changes: 5 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
@@ -17,15 +17,15 @@
"license": "MIT",
"require": {
"php": ">=7.1.3",
"arcanedev/support": "~4.4.0"
"arcanedev/support": "~4.5.0"
},
"require-dev": {
"orchestra/testbench": "~3.7.0",
"orchestra/testbench": "~3.8.0",
"mockery/mockery": "~1.0",
"phpunit/phpunit": "~7.0",
"phpunit/phpcov": "~5.0",
"phpunit/phpunit": "~7.0|~8.0",
"phpunit/phpcov": "~5.0|~6.0",
"predis/predis": "~1.1",
"illuminate/redis": "~5.7.0"
"illuminate/redis": "~5.8.0"
},
"autoload": {
"psr-4": {
4 changes: 2 additions & 2 deletions tests/SettingsManagerTest.php
Original file line number Diff line number Diff line change
@@ -21,14 +21,14 @@ class SettingsManagerTest extends TestCase
| -----------------------------------------------------------------
*/

protected function setUp()
protected function setUp(): void
{
parent::setUp();

$this->manager = $this->getSettingsManager();
}

protected function tearDown()
protected function tearDown(): void
{
unset($this->manager);

4 changes: 2 additions & 2 deletions tests/SettingsServiceProviderTest.php
Original file line number Diff line number Diff line change
@@ -21,14 +21,14 @@ class SettingsServiceProviderTest extends TestCase
| -----------------------------------------------------------------
*/

protected function setUp()
protected function setUp(): void
{
parent::setUp();

$this->provider = $this->app->getProvider(\Arcanedev\LaravelSettings\SettingsServiceProvider::class);
}

protected function tearDown()
protected function tearDown(): void
{
unset($this->provider);

2 changes: 1 addition & 1 deletion tests/Stores/JsonStoreTest.php
Original file line number Diff line number Diff line change
@@ -27,7 +27,7 @@ protected function createStore(array $data = [])
return $this->getStore('json')->setPath($path);
}

protected function tearDown()
protected function tearDown(): void
{
unlink($this->getFixtureFilePath());

2 changes: 1 addition & 1 deletion tests/Stores/RedisStoreTest.php
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ protected function createStore(array $data = [])
return $this->getStore('redis');
}

protected function tearDown()
protected function tearDown(): void
{
$this->createStore()->flush()->save();

2 changes: 1 addition & 1 deletion tests/TestCase.php
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ abstract class TestCase extends BaseTestCase
/**
* Setup the test environment.
*/
protected function setUp()
protected function setUp(): void
{
parent::setUp();

0 comments on commit b6c43bf

Please sign in to comment.