Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter fix #2650

Merged
merged 26 commits into from
Jul 18, 2023
Merged

Linter fix #2650

merged 26 commits into from
Jul 18, 2023

Conversation

GremlingSS
Copy link
Contributor

@GremlingSS GremlingSS commented Jul 17, 2023

Augh, attempts to fix linters cause I hate seeing red X's

For future reference:
Do not put mobs near other mobs not in the same faction, this leads to lots of errors.

  • When this is ticked, it do be ready

@GremlingSS
Copy link
Contributor Author

Okay! So the amount of changes I had to make were half map, half code.

The problem a lot of the time is that unit testing explosions is a bit different I believe to what it's like ingame, explosions I think I havent even looked, aren't functioning the same way they do in unit tests. Causing bunch of runtimes. This is because mobs during unit tests will fight eachother to the bone. (Because of mismatched factions)

I did a few changes to factions on some mobs, specifically to the drunken miner and Arlem, they both attacked mobs, one which even somehow manages to despawn from existence while trying to kill Arlem. (Which I think leads him to more issues I believe)

The stack code, I think that some stacks with 0 amount exist in some lists which aren't accessible, so it breaks a lot of initialization for some framework things it seems. So I've undone a tiny bit and fixed up where those 0 amount stacks may appear.

@Tk420634
Copy link
Contributor

bruh

@GremlingSS
Copy link
Contributor Author

drop-the-mic-obama-mic-drop

Copy link
Contributor

@Tk420634 Tk420634 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big stinki

@Tk420634 Tk420634 merged commit 60ab3d2 into ARF-SS13:master Jul 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants