Fix the profiling sample runtime #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent upstream change causes __llvm_profile_raw_version to be defined by the compiler, thus no need to define it in the runtime.
smithp35
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Looks good to me. Thanks for the update. My guess at the upstream change is https://reviews.llvm.org/D157913
voltur01
added a commit
to voltur01/LLVM-embedded-toolchain-for-Arm
that referenced
this pull request
Sep 27, 2023
This reverts commit de381f7.
voltur01
added a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent upstream change causes __llvm_profile_raw_version to be defined by the compiler, thus no need to define it in the runtime.