Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MinGW toolchain install with 'install-llvm-toolchain' #543

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix MinGW toolchain install with 'install-llvm-toolchain' #543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2195,7 +2195,7 @@ set(LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS_ALL ${LLVM_TOOLCHAIN_DISTRIBUTION_COM
if(LLVM_TOOLCHAIN_CROSS_BUILD_MINGW)
list(APPEND LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS_ALL llvm-toolchain-mingw)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this.

Looking again at it, I can't see any reason for LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS_ALL to exist it all, and it would make more sense for llvm-toolchain-mingw to be included in LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS instead of creating a duplicate list.

endif()
foreach(component ${LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS})
foreach(component ${LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS_ALL})
add_custom_target(
install-${component}
COMMAND
Expand Down